-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update status of Python 3 support #30722
Conversation
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support.
@sam-github, @cclauss this reflect my understanding, can you validate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions to simplify, but generally LGTM
Co-Authored-By: Michaël Zasso <[email protected]>
Given that Python 2 end of life is in 29 days, I would recommend the following simplification:
|
CI good, just waiting for Travis to complete. |
Travis is good landing. |
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Landed as 7bee77f |
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes