[v10.x] n-api: correct bug in napi_get_last_error #30532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
approved these changes
Nov 19, 2019
BethGriggs
approved these changes
Nov 19, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
napi_get_last_error returns incorrect napi_status. PR-URL: nodejs#28702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof
force-pushed
the
backport-28702-to-v10.x
branch
from
01f2c3a
to
d5a73ad
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2019
napi_get_last_error returns incorrect napi_status. Backport-PR-URL: #30532 PR-URL: #28702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 14e7a35 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
napi_get_last_error returns incorrect napi_status. Backport-PR-URL: #30532 PR-URL: #28702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
napi_get_last_error returns incorrect napi_status.
PR-URL: #28702
Reviewed-By: @jasnell
Reviewed-By: @gabrielschulhof
Reviewed-By: @cjihrig
Reviewed-By: @mhdawson
Re: #30487
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes