-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update outdated ESM/CommonJS compatibility info #30512
Closed
GeoffreyBooth
wants to merge
1
commit into
nodejs:master
from
GeoffreyBooth:fix-commonjs-compatibility-info
Closed
doc: update outdated ESM/CommonJS compatibility info #30512
GeoffreyBooth
wants to merge
1
commit into
nodejs:master
from
GeoffreyBooth:fix-commonjs-compatibility-info
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
approved these changes
Nov 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we please fast-track |
MylesBorins
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Nov 17, 2019
lpinca
approved these changes
Nov 17, 2019
Landed in 5c57616 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30512 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30512 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
PR-URL: #30512 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30512 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the text in the Interoperability with CommonJS section was out of date and no longer correct.
Checklist
cc @nodejs/modules-active-members