Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix util.format on checking object prototype 'toString' #30502

Closed
wants to merge 1 commit into from
Closed

lib: fix util.format on checking object prototype 'toString' #30502

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

fix #30333

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 16, 2019
devsnek
devsnek reviewed Nov 16, 2019
View reviewed changes
lib/internal/util/inspect.js Show resolved Hide resolved
lib/internal/util/inspect.js Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member

Duplicate of #30343. That solution is a bit more in depth, since it will also handle a few more edge cases (not triggering getters).

@himself65 himself65 closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek left review comments

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

util.format('%s', o) fails to call String(o) in certain cases
4 participants
@himself65 @BridgeAR @devsnek @nodejs-github-bot