Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix function and variable names in comments #3039

Closed

Conversation

thefourtheye
Copy link
Contributor

The src/node.js file is actually loaded and executed by
node::LoadEnvironment function.

The variable which has the contents is, native_node.

@thefourtheye thefourtheye added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 24, 2015
The `src/node.js` file is actually loaded and executed by
`node::LoadEnvironment` function.

The variable which has the contents is, `native_node`.
// This file is invoked by node::Load in src/node.cc, and responsible for
// bootstrapping the node.js core. Special caution is given to the performance
// of the startup process, so many dependencies are invoked lazily.
// This file is invoked by node::LoadEnvironment in src/node.cc, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably read "and is" instead of just "and."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscdex Sure, I updated it.

@bnoordhuis
Copy link
Member

LGTM

@thefourtheye
Copy link
Contributor Author

Thanks for the review @bnoordhuis :-) Landed in af881ad

thefourtheye added a commit that referenced this pull request Sep 25, 2015
The `src/node.js` file is actually loaded and executed by
`node::LoadEnvironment` function.

The variable which has the contents is, `native_node`.

PR-URL: #3039
Reviewed-By: Ben Noordhuis <[email protected]>
@thefourtheye thefourtheye deleted the fix-typos-in-comments branch September 25, 2015 10:57
thefourtheye added a commit that referenced this pull request Sep 30, 2015
The `src/node.js` file is actually loaded and executed by
`node::LoadEnvironment` function.

The variable which has the contents is, `native_node`.

PR-URL: #3039
Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants