doc: document ICU time zone data update process #30364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
jasnell
approved these changes
Nov 12, 2019
devnexen
approved these changes
Nov 12, 2019
|
It seems we have some linter issues (line length and list markers). |
apaprocki
force-pushed
the
icu-readme
branch
from
24f65cd
to
2915b8f
Compare
|
@srl295 FYI if you can take a look. |
3 tasks
|
although… @apaprocki could we merge this in to #30607 ? it could be subsection of the new |
apaprocki
force-pushed
the
icu-readme
branch
from
2915b8f
to
7cbbc3d
Compare
|
Ping @apaprocki |
1 similar comment
|
Ping @apaprocki |
|
I’ll away, will be back next week and can look at this. |
|
Ping @apaprocki |
apaprocki
changed the title
|
@srl295 Took a stab at it, let me know if you'd like anything different. I just guessed where it might fit into the flow of the other file. |
|
Looks great except drop the reference to “icu-small”
S
El El dom, ene. 12, 2020 a la(s) 12:10 p. m., Andrew Paprocki <
[email protected]> escribió:
… @srl295 <https://github.com/srl295> Took a stab at it, let me know if
you'd like anything different. I just guessed where it might fit into the
flow of the other file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30364?email_source=notifications&email_token=AAGQZMZWXS3TRMR5GPSMGNLQ5N2LRA5CNFSM4JL42FLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXC7GQ#issuecomment-573452186>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM66ACWF3SOASVMRFZLQ5N2LRANCNFSM4JL42FLA>
.
|
Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in nodejs#30211 by @srl295
srl295
approved these changes
May 11, 2020
|
@apaprocki I'll work on landing this… it's passed the linter already so should be fine |
2 tasks
|
ahh - still need to land. |
srl295
pushed a commit
that referenced
this pull request
May 19, 2020
Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in #30211 by @srl295 PR-URL: #30364 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Steven R Loomis <[email protected]>
|
Landed in fe1b9e0 |
codebytere
pushed a commit
that referenced
this pull request
May 21, 2020
Updates the "Maintaining ICU" document and describes the process to update an existing ICU `.dat` file with updated binary time zone data files corresponding to new IANA `tzdata` releases. Requested in #30211 by @srl295 PR-URL: #30364 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Steven R Loomis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the "Maintaining ICU" document and describes the process
to update an existing ICU
.datfile with updated binary timezone data files corresponding to new IANA
tzdatareleases.Requested in #30211 by @srl295