Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise os.md #30102

Merged
merged 0 commits into from
Oct 26, 2019
Merged

doc: revise os.md #30102

merged 0 commits into from
Oct 26, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 24, 2019

Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 24, 2019
gireeshpunathil
gireeshpunathil reviewed Oct 24, 2019
View reviewed changes
doc/api/os.md Outdated Show resolved Hide resolved
cjihrig
cjihrig approved these changes Oct 24, 2019
View reviewed changes
doc/api/os.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Oct 26, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4013/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2019
@Trott
Copy link
Member Author

Trott commented Oct 26, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4014/

@Trott Trott closed this Oct 26, 2019
@Trott Trott merged commit 7b2de22 into nodejs:master Oct 26, 2019
@Trott
Copy link
Member Author

Trott commented Oct 26, 2019

Landed in 7b2de22

targos pushed a commit that referenced this pull request Oct 28, 2019
@Trott @targos
doc: revise os.md
9a71091 
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

PR-URL: #30102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@Trott @targos
doc: revise os.md
1d427ed 
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

PR-URL: #30102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@Trott @targos
doc: revise os.md
7189220 
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

PR-URL: #30102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@Trott @targos
doc: revise os.md
6ebe99b 
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

PR-URL: #30102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@Trott @targos
doc: revise os.md
ec99287 
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

PR-URL: #30102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the revise-os-doc branch January 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @cjihrig @gireeshpunathil @trivikr @nodejs-github-bot