-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: --enable-source-maps and prepareStackTrace are incompatible #30046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see nodejs#29994
nodejs-github-bot
added
cli
Issues and PRs related to the Node.js command line interface.
doc
Issues and PRs related to the documentations.
labels
Oct 21, 2019
devsnek
approved these changes
Oct 21, 2019
joyeecheung
reviewed
Oct 21, 2019
cjihrig
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the suggestions incorporated.
lpinca
approved these changes
Oct 21, 2019
joyeecheung
approved these changes
Oct 22, 2019
bcoe
added a commit
that referenced
this pull request
Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Landed in b964e77 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2019
document the fact that --enable-source-maps and prepareStackTrace are incompatible, see #29994 PR-URL: #30046 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Issues and PRs related to the Node.js command line interface.
doc
Issues and PRs related to the documentations.
source maps
Issues and PRs related to source map support.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document the fact that
--enable-source-maps
andprepareStackTrace
areincompatible, see #29994
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes