Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: --enable-source-maps and prepareStackTrace are incompatible #30046

Closed
wants to merge 3 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 21, 2019

document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see nodejs#29994
@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Oct 21, 2019
doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestions incorporated.

@nodejs-github-bot
Copy link
Collaborator

bcoe added a commit that referenced this pull request Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@bcoe
Copy link
Contributor Author

bcoe commented Oct 23, 2019

Landed in b964e77

@bcoe bcoe closed this Oct 23, 2019
@bcoe bcoe deleted the doc-29994 branch October 23, 2019 06:07
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
@addaleax addaleax added the source maps Issues and PRs related to source map support. label Nov 2, 2019
targos pushed a commit that referenced this pull request Nov 8, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. source maps Issues and PRs related to source map support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants