tools: prohibit Error.prepareStackTrace usage #29827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eslint rule makes sure that `prepareStackTrace` is not used in Node.js core.
devsnek
reviewed
Oct 3, 2019
jasnell
approved these changes
Oct 3, 2019
devsnek
approved these changes
Oct 3, 2019
Trott
pushed a commit
that referenced
this pull request
Oct 6, 2019
This eslint rule makes sure that `prepareStackTrace()` is not used in Node.js core. PR-URL: #29827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
|
Landed in 0521a98 If the reason for avoiding prepareStackTrace() isn't already documented somewhere, it would be a good idea to add it somewhere, perhaps doc/guides/using-internal-errors.md. |
BridgeAR
added a commit
that referenced
this pull request
Oct 9, 2019
This eslint rule makes sure that `prepareStackTrace()` is not used in Node.js core. PR-URL: #29827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eslint rule makes sure that
prepareStackTraceis not used inNode.js core.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes