Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: added note about undocumented API #29805

Closed
wants to merge 2 commits into from
Closed

stream: added note about undocumented API #29805

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 1, 2019

I've double checked this is not causing any problems anywhere but I still think it is worth to add a note for future core programmers just in case.

Checklist

addaleax
addaleax approved these changes Oct 1, 2019
View reviewed changes
lib/internal/streams/destroy.js Outdated Show resolved Hide resolved
@BridgeAR BridgeAR added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Oct 1, 2019
@Trott
Copy link
Member

Trott commented Oct 3, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3963/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2019
@Trott
Copy link
Member

Trott commented Oct 3, 2019

Landed in 4fa1744

@Trott Trott closed this Oct 3, 2019
Trott pushed a commit that referenced this pull request Oct 3, 2019
@ronag @Trott
stream: add comment about undocumented API
4fa1744 
PR-URL: #29805
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@ronag @BridgeAR
stream: add comment about undocumented API
320f649 
PR-URL: #29805
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ronag @Trott @addaleax @lpinca @cjihrig @JungMinu @BridgeAR @shisama @trivikr