Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,http: optional callback for setTimeout #29654

Closed
wants to merge 1 commit into from
Closed

doc,http: optional callback for setTimeout #29654

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 22, 2019

Documents that callback is optional for IncomingMessage setTimeout

node/lib/_http_incoming.js

Lines 88 to 89 in 0daec61

if (callback)
this.on('timeout', callback);

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Sep 22, 2019
@trivikr
Copy link
Member Author

trivikr commented Sep 22, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3920/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 22, 2019
@trivikr @Trott
doc,http: optional callback for setTimeout
18d529e 
Documents that callback is optional for IncomingMessage setTimeout
@Trott Trott force-pushed the http-incomingmessage-callback-optional branch from 1e157f4 to 18d529e Compare September 22, 2019 20:20
@Trott
Copy link
Member

Trott commented Sep 25, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3932/

@Trott
Copy link
Member

Trott commented Sep 25, 2019

Landed in 7333c71

@Trott Trott closed this Sep 25, 2019
Trott pushed a commit that referenced this pull request Sep 25, 2019
@trivikr @Trott
doc,http: indicate callback is optional for message.setTimeout()
7333c71 
Documents that callback is optional for IncomingMessage setTimeout

PR-URL: #29654
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2019
@trivikr @targos
doc,http: indicate callback is optional for message.setTimeout()
6579b1a 
Documents that callback is optional for IncomingMessage setTimeout

PR-URL: #29654
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
@trivikr trivikr deleted the http-incomingmessage-callback-optional branch August 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trivikr @Trott @jasnell @lpinca @cjihrig @BridgeAR @nodejs-github-bot