Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: cleanup use of _readableState.ended #29645

Closed
wants to merge 2 commits into from
Closed

stream: cleanup use of _readableState.ended #29645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93fb54a
stream: cleanup use of internal ended state
ckarande Sep 21, 2019
dacc241
stream: add test for multiple .push(null)
ckarande Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ class Http2ServerRequest extends Readable {

get complete() {
return this[kAborted] ||
this._readableState.ended ||
this.readableEnded ||
this[kState].closed ||
this[kStream].destroyed;
}
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,11 @@ class Worker extends EventEmitter {

const { stdout, stderr } = this[kParentSideStdio];

if (!stdout._readableState.ended) {
if (!stdout.readableEnded) {
debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
stdout.push(null);
}
if (!stderr._readableState.ended) {
if (!stderr.readableEnded) {
debug(`[${threadId}] explicitly closes stderr for ${this.threadId}`);
stderr.push(null);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ function afterShutdown(status) {
if (self.destroyed)
return;

if (!self.readable || self._readableState.ended) {
if (!self.readable || self.readableEnded) {
debug('readableState ended, destroying');
self.destroy();
}
Expand Down