Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: remove not exist entries from inspect #29528

Closed
wants to merge 2 commits into from

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Sep 11, 2019

Some of the milestones was removed in PR #21247 but entries not removed
from function for inspect PerformanceNodeTiming.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Some of the milestones was removed in PR nodejs#21247 but entries not removed
from function for inspect PerformanceNodeTiming.
@nodejs-github-bot nodejs-github-bot added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Sep 11, 2019
@trivikr
Copy link
Member

trivikr commented Sep 11, 2019

@jasnell Should these be removed from test-trace-events-bootstrap.js too?

'thirdPartyMainStart',
'thirdPartyMainEnd',
'clusterSetupStart',
'clusterSetupEnd',
'moduleLoadStart',
'moduleLoadEnd',
'preloadModulesLoadStart',
'preloadModulesLoadEnd'

@jasnell
Copy link
Member

jasnell commented Sep 11, 2019

Yeah they should

@trivikr
Copy link
Member

trivikr commented Sep 11, 2019

Yeah they should

@fanatid would you also like to remove following entries in this PR?

'thirdPartyMainStart',
'thirdPartyMainEnd',
'clusterSetupStart',
'clusterSetupEnd',
'moduleLoadStart',
'moduleLoadEnd',
'preloadModulesLoadStart',
'preloadModulesLoadEnd'

@fanatid
Copy link
Contributor Author

fanatid commented Sep 12, 2019

Removed.

@trivikr
Copy link
Member

trivikr commented Sep 12, 2019

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Sep 13, 2019

Landed in 39eb894

@Trott Trott closed this Sep 13, 2019
Trott pushed a commit that referenced this pull request Sep 13, 2019
Some of the milestones was removed in PR #21247 but entries not removed
from function for inspect PerformanceNodeTiming.

PR-URL: #29528
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@fanatid fanatid deleted the perf_hooks-remove-node-inspect branch September 13, 2019 20:54
targos pushed a commit that referenced this pull request Sep 20, 2019
Some of the milestones was removed in PR #21247 but entries not removed
from function for inspect PerformanceNodeTiming.

PR-URL: #29528
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Some of the milestones was removed in PR #21247 but entries not removed
from function for inspect PerformanceNodeTiming.

PR-URL: #29528
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants