Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove wrong escapes #29452

Closed
wants to merge 1 commit into from
Closed

doc: remove wrong escapes #29452

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

I noticed these in the nodejs.org repo and thought I'd fix them here too.

This should probably be automated, but I don't have the bandwidth to do this myself. Also, I'm not quite sure if this can be safely automated, since there are cases one needs to use \ (for example WIndows paths).

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 5, 2019
@trivikr
Copy link
Member

trivikr commented Sep 5, 2019

Are these escapes automatically added on new releases? If yes, can they be ignored/avoided?

Example commit for 12.10.0 02c74e7
Line which has escape: Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
Corresponding commit doesn't have escape b245257

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 6, 2019

If you mean \*timeNs there it's needed because it's not wrapped in code thus * needs to be escaped.

@Trott
Copy link
Member

Trott commented Sep 7, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3893/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2019
@Trott
Copy link
Member

Trott commented Sep 8, 2019

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3894/

Trott pushed a commit that referenced this pull request Sep 8, 2019
@XhmikosR @Trott
doc: remove wrong escapes
ab05d43 
PR-URL: #29452
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Sep 8, 2019

Landed in ab05d43

@Trott Trott closed this Sep 8, 2019
@XhmikosR XhmikosR deleted the master-xmr-doc-escapes branch September 9, 2019 04:04
targos pushed a commit that referenced this pull request Sep 20, 2019
@XhmikosR @targos
doc: remove wrong escapes
f151b0a 
PR-URL: #29452
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@XhmikosR @BridgeAR
doc: remove wrong escapes
b1509e8 
PR-URL: #29452
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XhmikosR @trivikr @Trott @cjihrig @nodejs-github-bot