Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: delete v8_external_snapshot.gypi #29369

Closed
wants to merge 3 commits into from
Closed

tools: delete v8_external_snapshot.gypi #29369

wants to merge 3 commits into from

Commits on Aug 29, 2019

  1. tools: delete v8_external_snapshot.gypi 

    Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.

Refs: nodejs#29363 (comment)
Fixes: nodejs#28964
    @ryzokuken
    ryzokuken committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    5adb3c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. fixup! tools: delete v8_external_snapshot.gypi

    @ryzokuken
    ryzokuken committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    57f6c83 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. fixup! tools: delete v8_external_snapshot.gypi

    @ryzokuken
    ryzokuken committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    c4ad2b1 View commit details
    Browse the repository at this point in the history