test: fix flaky test-http-server-keepalive-req-gc #29347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
This comment has been minimized.
This comment has been minimized.
addaleax
reviewed
Aug 27, 2019
addaleax
approved these changes
Aug 27, 2019
Trott
changed the title
|
CI is green. Some approvals for fast-tracking would be great.... @nodejs/testing |
Use `server` to keep the event loop open until the `ongc` listener runs. Fixes: nodejs#29344
|
Actually, can you maybe also try to remove the skip-on-Windows part? That might be resolved now too |
I was going to do that in a follow-up PR, just in case it's not resolved. Is that OK with you? |
|
Sure! |
danbev
approved these changes
Aug 28, 2019
Trott
added
the
author ready
|
Collaborators, please 👍 to fast-track. |
danbev
pushed a commit
that referenced
this pull request
Aug 28, 2019
Use `server` to keep the event loop open until the `ongc` listener runs. PR-URL: #29347 Fixes: #29344 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
|
Landed in 3ae6f5e. |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Use `server` to keep the event loop open until the `ongc` listener runs. PR-URL: #29347 Fixes: #29344 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Use `server` to keep the event loop open until the `ongc` listener runs. PR-URL: #29347 Fixes: #29344 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
serverto keep the event loop open until theongclistener runs.Fixes: #29344
Collaborators, please 👍 to fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes