Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: avoid passing unnecessary loop reference #29275

Closed
wants to merge 1 commit into from
Closed

module: avoid passing unnecessary loop reference #29275

wants to merge 1 commit into from

Conversation

saghul
Copy link
Member

@saghul saghul commented Aug 22, 2019

It's a sync request, which doesn't require the loop parameter to be set.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@saghul saghul requested a review from cjihrig August 22, 2019 21:44
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 22, 2019
@saghul
module: avoid passing unnecessary loop reference
ac00eb4 
It's a sync request, which doesn't require the loop parameter to be set.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25190/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 23, 2019
saghul added a commit that referenced this pull request Aug 23, 2019
@saghul
module: avoid passing unnecessary loop reference
2fc8768 
It's a sync request, which doesn't require the loop parameter to be set.

PR-URL: #29275
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@saghul
Copy link
Member Author

saghul commented Aug 23, 2019

Landed in 2fc8768 thanks for the quick reviews!

@saghul saghul closed this Aug 23, 2019
@addaleax addaleax mentioned this pull request Aug 28, 2019
Closed
4 tasks
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@saghul @BridgeAR
module: avoid passing unnecessary loop reference
eb2d96f 
It's a sync request, which doesn't require the loop parameter to be set.

PR-URL: #29275
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saghul @nodejs-github-bot @jasnell @addaleax @cjihrig @richardlau