-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8.x] http2: mitigate reported DoS attacks #29124
Commits on Aug 13, 2019
-
http2: improve http2 code a bit
Multiple general improvements to http2 internals for readability and efficiency [This backport applied to v10.x cleanly but had several merge conflicts on v8.x.] PR-URL: nodejs#23984 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d09a44 - Browse repository at this point
Copy the full SHA 4d09a44View commit details -
deps: update nghttp2 to 1.34.0
Key new feature: RFC 8441 `:protocol` support PR-URL: nodejs#23284 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b8b4ba5 - Browse repository at this point
Copy the full SHA b8b4ba5View commit details -
deps: update nghttp2 to 1.37.0
PR-URL: nodejs#26990 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6251b50 - Browse repository at this point
Copy the full SHA 6251b50View commit details -
deps: update nghttp2 to 1.38.0
PR-URL: nodejs#27295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 68a44ab - Browse repository at this point
Copy the full SHA 68a44abView commit details -
deps: update nghttp2 to 1.39.1
PR-URL: nodejs#28448 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6a1278b - Browse repository at this point
Copy the full SHA 6a1278bView commit details
Commits on Aug 14, 2019
-
deps: update nghttp2 to 1.39.2
This includes mitigations for CVE-2019-9512/CVE-2019-9515.
Configuration menu - View commit details
-
Copy full SHA for 6deff8a - Browse repository at this point
Copy the full SHA 6deff8aView commit details -
http2: improve JS-side debug logging
DRY up the `debug()` calls, and in particular, avoid building template strings before we know whether we need to.
Configuration menu - View commit details
-
Copy full SHA for 14fd420 - Browse repository at this point
Copy the full SHA 14fd420View commit details -
http2: only call into JS when necessary for session events
For some JS events, it only makes sense to call into JS when there are listeners for the event in question. The overhead is noticeable if a lot of these events are emitted during the lifetime of a session. To reduce this overhead, keep track of whether any/how many JS listeners are present, and if there are none, skip calls into JS altogether. This is part of performance improvements to mitigate CVE-2019-9513.
Configuration menu - View commit details
-
Copy full SHA for dd6b143 - Browse repository at this point
Copy the full SHA dd6b143View commit details -
http2: do not create ArrayBuffers when no DATA received
Lazily allocate `ArrayBuffer`s for the contents of DATA frames. Creating `ArrayBuffer`s is, sadly, not a cheap operation with V8. This is part of performance improvements to mitigate CVE-2019-9513. Together with the previous commit, these changes improve throughput in the adversarial case by about 100 %, and there is little more that we can do besides artificially limiting the rate of incoming metadata frames (i.e. after this patch, CPU usage is virtually exclusively in libnghttp2). [This backport also applies changes from 83e1b97 and required some manual work due to the lack of `AllocatedBuffer` on v10.x. More work was necessary for v8.x, including copying utilities for `util.h` from more recent Node.js versions.] Refs: nodejs#26201
Configuration menu - View commit details
-
Copy full SHA for f717523 - Browse repository at this point
Copy the full SHA f717523View commit details -
http2: limit number of rejected stream openings
Limit the number of streams that are rejected upon creation. Since each such rejection is associated with an `NGHTTP2_ENHANCE_YOUR_CALM` error that should tell the peer to not open any more streams, continuing to open streams should be read as a sign of a misbehaving peer. The limit is currently set to 100 but could be changed or made configurable. This is intended to mitigate CVE-2019-9514.
Configuration menu - View commit details
-
Copy full SHA for 7652406 - Browse repository at this point
Copy the full SHA 7652406View commit details -
http2: limit number of invalid incoming frames
Limit the number of invalid input frames, as they may be pointing towards a misbehaving peer. The limit is currently set to 1000 but could be changed or made configurable. This is intended to mitigate CVE-2019-9514. [This commit differs from the v12.x one due to the lack of libuv/libuv@ee24ce900e5714c950b248da2b. See the comment in the test for more details.]
Configuration menu - View commit details
-
Copy full SHA for 871393f - Browse repository at this point
Copy the full SHA 871393fView commit details -
http2: handle 0-length headers better
Ignore headers with 0-length names and track memory for headers the way we track it for other HTTP/2 session memory too. This is intended to mitigate CVE-2019-9516.
Configuration menu - View commit details
-
Copy full SHA for a722e8c - Browse repository at this point
Copy the full SHA a722e8cView commit details -
http2: shrink default
vector::reserve()
allocationsAllocating memory upfront comes with overhead, and in particular, `std::vector` implementations do not necessarily return memory to the system when one might expect that (e.g. after shrinking the vector).
Configuration menu - View commit details
-
Copy full SHA for cda3bad - Browse repository at this point
Copy the full SHA cda3badView commit details -
http2: consider 0-length non-end DATA frames an error
This is intended to mitigate CVE-2019-9518.
Configuration menu - View commit details
-
Copy full SHA for 4993fa7 - Browse repository at this point
Copy the full SHA 4993fa7View commit details -
http2: stop reading from socket if writes are in progress
If a write to the underlying socket finishes asynchronously, that means that we cannot write any more data at that point without waiting for it to finish. If this happens, we should also not be producing any more input. This is part of mitigating CVE-2019-9511/CVE-2019-9517.
Configuration menu - View commit details
-
Copy full SHA for 6a341af - Browse repository at this point
Copy the full SHA 6a341afView commit details -
http2: pause input processing if sending output
If we are waiting for the ability to send more output, we should not process more input. This commit a) makes us send output earlier, during processing of input, if we accumulate a lot and b) allows interrupting the call into nghttp2 that processes input data and resuming it at a later time, if we do find ourselves in a position where we are waiting to be able to send more output. This is part of mitigating CVE-2019-9511/CVE-2019-9517.
Configuration menu - View commit details
-
Copy full SHA for bc112af - Browse repository at this point
Copy the full SHA bc112afView commit details -
http2: allow security revert for Ping/Settings Flood
nghttp2 has updated its limit for outstanding Ping/Settings ACKs to 1000. This commit allows reverting to the old default of 10000. The associated CVEs are CVE-2019-9512/CVE-2019-9515.
Configuration menu - View commit details
-
Copy full SHA for 6912e21 - Browse repository at this point
Copy the full SHA 6912e21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 320fbea - Browse repository at this point
Copy the full SHA 320fbeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5db3a94 - Browse repository at this point
Copy the full SHA 5db3a94View commit details