Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: buffer writes while no socket #29019

Closed
wants to merge 1 commit into from
Closed

http: buffer writes while no socket #29019

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 6, 2019 •
edited
Loading

We should be buffering writes even while no socket is assigned.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Aug 6, 2019
@ronag ronag force-pushed the http-buffer-even-while-no-socket branch 2 times, most recently from 7e038a5 to 6cc9e2f Compare August 6, 2019 13:50
@ronag ronag changed the title http: buffer while no socket http: buffer writes while no socket Aug 6, 2019
@ronag ronag force-pushed the http-buffer-even-while-no-socket branch from 6cc9e2f to 292dac1 Compare August 6, 2019 13:54
@ronag ronag mentioned this pull request Aug 6, 2019
Closed
4 tasks
lpinca
lpinca reviewed Aug 6, 2019
View reviewed changes
lib/_http_outgoing.js Outdated Show resolved Hide resolved
test/parallel/test-http-outgoing-buffer.js Outdated Show resolved Hide resolved
@lpinca
Copy link
Member

lpinca commented Aug 6, 2019

Seems good to me with the getHighWaterMark() issue addressed.

@ronag ronag force-pushed the http-buffer-even-while-no-socket branch 6 times, most recently from 6de1993 to 355f5b7 Compare August 6, 2019 23:24
@ronag ronag force-pushed the http-buffer-even-while-no-socket branch 5 times, most recently from 53d503b to 0f8400b Compare August 8, 2019 11:11
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24897/

@ronag ronag force-pushed the http-buffer-even-while-no-socket branch from 0f8400b to d37b213 Compare August 9, 2019 16:02
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24912/

@Trott
Copy link
Member

Trott commented Aug 9, 2019

@nodejs/streams

mcollina
mcollina approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Aug 9, 2019

Landed in c065773

@Trott Trott closed this Aug 9, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 9, 2019
@ronag @Trott
http: buffer writes even while no socket assigned
c065773 
PR-URL: nodejs#29019
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
@ronag @targos
http: buffer writes even while no socket assigned
c396b2a 
PR-URL: #29019
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @lpinca @nodejs-github-bot @Trott @mcollina