Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: list envvars using uv_os_environ() #28963

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 5, 2019

Note: This PR is a bit premature. It requires the libuv 1.31.0 update, which will happen later this week. Only the second commit (report: list envvars using uv_os_environ()) is relevant. libuv 1.31.0 includes a new API, uv_os_environ(), for iterating over the environment variables.

This PR simplifies the diagnostic report's code for listing environment variables by using uv_os_environ() instead of platform specific code.

cc: @nodejs/libuv

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 5, 2019
@cjihrig cjihrig added the blocked PRs that are blocked by other issues or PRs. label Aug 5, 2019
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/node_report.cc Outdated Show resolved Hide resolved
@cjihrig cjihrig force-pushed the envvars branch 3 times, most recently from 8b89159 to 097a154 Compare August 11, 2019 15:35
@cjihrig cjihrig added report Issues and PRs related to process.report. and removed blocked PRs that are blocked by other issues or PRs. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 11, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 11, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24939/

EDIT: CI was yellow.

This commit simplifies the diagnostic report's code for listing
environment variables by using uv_os_environ() instead of
platform specific code.

PR-URL: nodejs#28963
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants