Revert "module: implement "exports" proposal for CommonJS"

[Trott]

This reverts commit dcb6929.

Unfortunately, dcb6929 was landed despite apparently-unrelated tests failing in CI on the debug build. However, after it landed, those tests started failing 100% on master. I did a git bisect and used Jenkins to determine that dcb6929 is the commit that caused the issue.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24671/

[Trott]

CI is above, but here's a node-daily-master kicked off manually just now (so a CI against current master) that should show the failure. https://ci.nodejs.org/job/node-daily-master/1621/

[Trott]

Failures on master:

https://ci.nodejs.org/job/node-test-commit-linux-containered/14070/nodes=ubuntu1604_sharedlibs_debug_x64/console

test-digitalocean-ubuntu1604_sharedlibs_container-x64-7

15:11:56 not ok 2435 sequential/test-cpu-prof-dir-worker
15:11:56   ---
15:11:56   duration_ms: 1.213
15:11:56   severity: fail
15:11:56   exitcode: 1
15:11:56   stack: |-
15:11:56     Dispatching message { "id": 1, "method": "Profiler.enable" }
15:11:56     Receive CPU profile message, ending = false
15:11:56     Dispatching message { "id": 2, "method": "Profiler.start" }
15:11:56     Receive CPU profile message, ending = false
15:11:56     Dispatching message { "id": 3, "method": "Profiler.setSamplingInterval", "params": { "interval": 50 } }
15:11:56     Receive CPU profile message, ending = false
15:11:56     Dispatching message { "id": 1, "method": "Profiler.enable" }
15:11:56     Receive CPU profile message, ending = false
15:11:56     Dispatching message { "id": 2, "method": "Profiler.start" }
15:11:56     Receive CPU profile message, ending = false
15:11:56     Dispatching message { "id": 3, "method": "Profiler.setSamplingInterval", "params": { "interval": 50 } }
15:11:56     Receive CPU profile message, ending = false
15:11:56     
15:11:56     assert.js:89
15:11:56       throw new AssertionError(obj);
15:11:56       ^
15:11:56     
15:11:56     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
15:11:56     
15:11:56     null !== 0
15:11:56     
15:11:56         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/sequential/test-cpu-prof-dir-worker.js:39:10)
15:11:56         at Module._compile (internal/modules/cjs/loader.js:866:30)
15:11:56         at Object.Module._extensions..js (internal/modules/cjs/loader.js:877:10)
15:11:56         at Module.load (internal/modules/cjs/loader.js:729:32)
15:11:56         at Function.Module._load (internal/modules/cjs/loader.js:642:12)
15:11:56         at Function.Module.runMain (internal/modules/cjs/loader.js:929:10)
15:11:56         at internal/main/run_main_module.js:17:11 {
15:11:56       generatedMessage: true,
15:11:56       code: 'ERR_ASSERTION',
15:11:56       actual: null,
15:11:56       expected: 0,
15:11:56       operator: 'strictEqual'
15:11:56     }
15:11:56   ...
15:11:56 ok 2436 sequential/test-cpu-prof-drained
15:11:56   ---
15:11:56   duration_ms: 0.812
15:11:56   ...
15:11:57 ok 2437 sequential/test-cpu-prof-exit
15:11:57   ---
15:11:57   duration_ms: 0.913
15:11:57   ...
15:11:58 ok 2438 sequential/test-cpu-prof-invalid-options
15:11:58   ---
15:11:58   duration_ms: 0.411
15:11:58   ...
15:11:59 ok 2439 sequential/test-cpu-prof-kill
15:11:59   ---
15:11:59   duration_ms: 0.911
15:11:59   ...
15:11:59 ok 2440 sequential/test-cpu-prof-name
15:11:59   ---
15:11:59   duration_ms: 0.712
15:11:59   ...
15:12:01 not ok 2441 sequential/test-cpu-prof-worker-argv
15:12:01   ---
15:12:01   duration_ms: 1.112
15:12:01   severity: fail
15:12:01   exitcode: 1
15:12:01   stack: |-
15:12:01     
15:12:01     assert.js:89
15:12:01       throw new AssertionError(obj);
15:12:01       ^
15:12:01     
15:12:01     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
15:12:01     
15:12:01     null !== 0
15:12:01     
15:12:01         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/sequential/test-cpu-prof-worker-argv.js:34:10)
15:12:01         at Module._compile (internal/modules/cjs/loader.js:866:30)
15:12:01         at Object.Module._extensions..js (internal/modules/cjs/loader.js:877:10)
15:12:01         at Module.load (internal/modules/cjs/loader.js:729:32)
15:12:01         at Function.Module._load (internal/modules/cjs/loader.js:642:12)
15:12:01         at Function.Module.runMain (internal/modules/cjs/loader.js:929:10)
15:12:01         at internal/main/run_main_module.js:17:11 {
15:12:01       generatedMessage: true,
15:12:01       code: 'ERR_ASSERTION',
15:12:01       actual: null,
15:12:01       expected: 0,
15:12:01       operator: 'strictEqual'
15:12:01     }
15:12:01   ...

[addaleax]

LGTM

I’m currently building a debug build to look into this – but if I don’t figure anything out soon, it’s probably best to revert 👍

[jkrems]

Ugh, really sorry for that. :( Really curious how that side effect happened.

[Trott]

CI for this PR is green.

Fast-track to get CI back to green? Collaborators, 👍 to approve.

[addaleax]

So … I’m not sure there’s an issue for these failing tests (so I’m commenting here), but the test crashes because the PR changed GC timing and that in turn exposes a pre-existing bug in V8’s CPU profiler code. #28453 was blocked by the same issue.

As I’ve commented there, the fix would be backporting v8/v8@b107214. I think I can do that relatively quickly, now that it’s a bit more urgent. :)

(That being said, if you or somebody else wants to land this now, I’m happy to just revert the revert.)

[addaleax]

I’m closing this as #28850 landed, thanks for bringing attention to this issue!

[Trott]

@addaleax Thanks for fixing it and avoiding a revert! 🎉