Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] console: add trace-events for time and count #28840

Conversation

andrewhughes101
Copy link
Contributor

Add the node.console trace event category to capture
console.count(), console.countReset(), console.time(),
console.timeLog(), and console.timeEnd() to the trace
event log.

PR-URL: #23703
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Richard Lau [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. v10.x labels Jul 24, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@BethGriggs BethGriggs added the needs-ci PRs that need a full CI run. label Oct 7, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 25, 2020

@BethGriggs
Copy link
Member

@andrewhughes101, based on the history of this test on v10.x I think the module count number should be incremented by 1 in parallel/test-bootstrap-modules

Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: nodejs#23703
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29534/ ✅ - CI is known OSX failures from adding 10.15

@BethGriggs BethGriggs removed the needs-ci PRs that need a full CI run. label Mar 5, 2020
BethGriggs pushed a commit that referenced this pull request Mar 9, 2020
Add the `node.console` trace event category to capture
`console.count()`, `console.countReset()`, `console.time()`,
`console.timeLog()`, and `console.timeEnd()` to the trace
event log.

PR-URL: #23703
Backport-PR-URL: #28840
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs
Copy link
Member

Landed in b164a2e

@BethGriggs BethGriggs closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants