Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: avoid potentially misleading reference to object identity #28824

Closed
wants to merge 1 commit into from
Closed

assert: avoid potentially misleading reference to object identity #28824

wants to merge 1 commit into from

Commits on Jul 23, 2019

  1. assert: avoid potentially misleading reference to object identity 

    Often, the word “identical” when referring to JS objects will
be read as referring to having the same object identity (which is
called “reference equality” here), but what the error message is
trying to say here is that the objects are different but yield the
same `util.inspect()` output.

Since `util.inspect()` output represents the structure rather than
the identity of objects, (hopefully) clarify the error message to
reflect that.
    @addaleax
    addaleax committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    43cc444 View commit details
    Browse the repository at this point in the history