Commits on Jul 12, 2019

1. deps: cherry-pick 13a04aba from V8 upstream …

   Original commit message:
     fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references
   
     This change fixes missing symbol errors in the Windows 10 on ARM build
     of Node.js.
   
     When a whole class is marked for export, all of its members are marked
     as well. This can be a problem when inline members call undefined yet
     inline members of other classes: the exported function will contain a
     reference to the undefined inline function that should be satisfied at
     link time, but because the other function is inline no symbol will be
     produced that will satisfy that reference.
   
     Clang gets around this by masking inlined class members from export
     using /Fc:dllexportInlines-. This is why b0a2a567 worked.
   
     Node.js' Windows builds use MSVC and so do not have access to this
     flag. This results in unresolved symbols at link time.
   
     Bug: v8:9465
     Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
     Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771
     Reviewed-by: Sigurd Schneider <[email protected]>
     Reviewed-by: Jakob Gruber <[email protected]>
     Commit-Queue: Sigurd Schneider <[email protected]>
     Cr-Commit-Position: refs/heads/master@{#62660}
   
   Refs: v8/v8@13a04ab
   PR-URL: nodejs#28602

   

   jkunkee committed Jul 12, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 71e5f31
   • Browse repository at this point

   Copy the full SHA

   71e5f31 View commit details

   Browse the repository at this point in the history