doc: merge bootstrap/README.md into BUILDING.md #28465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus some minor tweaks
nodejs-github-bot
added
doc
bnoordhuis
approved these changes
Jun 28, 2019
sam-github
approved these changes
Jun 28, 2019
richardlau
approved these changes
Jun 28, 2019
lpinca
reviewed
Jun 28, 2019
jasnell
approved these changes
Jun 30, 2019
Trott
approved these changes
Jun 30, 2019
trivikr
approved these changes
Jul 1, 2019
trivikr
added
the
author ready
bzoz
approved these changes
Jul 1, 2019
trivikr
removed
the
author ready
|
landed in b12528f |
rvagg
added a commit
that referenced
this pull request
Jul 2, 2019
plus some minor tweaks PR-URL: #28465 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
|
this included a minor boo boo in the link from bootstrap/README.md, addressed in #28504 |
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
plus some minor tweaks PR-URL: #28465 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
plus some minor tweaks PR-URL: #28465 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #28264 - remove bootstrap/README.md and merge its contents into BUILDING.md so we don't have duplication, conflicts or confusion.
Includes some other minor reorg and tweaks.
/cc @nodejs/build