Centos7 ppc64 le v8 test support #28458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present.
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job.
sam-github
force-pushed
the
centos7-ppc64-le-v8-test-support
branch
from
1166b09
to
c3db2ca
Compare
|
centos7-ppcle passed in: https://ci.nodejs.org/job/node-test-commit-v8-linux/2396/nodes=centos7-ppcle,v8test=v8test/console repeat the builds: lite ci: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3726/ PASS v8 ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/2399/ PASS |
|
Are the three new Python scripts meant to be called from an existing Python/shell script? |
|
@richardlau Sorry, pulled the commit message details into the description. I wish github did that for me on multi-commit PRs. |
richardlau
approved these changes
Jun 28, 2019
|
Can I fast-track this, @nodejs/build @targos ? |
|
+1 to fast track from me |
Trott
approved these changes
Jun 30, 2019
danbev
pushed a commit
that referenced
this pull request
Jul 2, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danbev
pushed a commit
that referenced
this pull request
Jul 2, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Jul 3, 2019
cclauss
added
the
python
BethGriggs
pushed a commit
that referenced
this pull request
Nov 19, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 19, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one:
two:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes