Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 6.9.1 #28441

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 6.9.1 #28441

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jun 26, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 12
  • Node 10
  • Node 8
Notable changes
  • none
Changelogs

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jun 26, 2019
Trott
Trott approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24199/

@isaacs
Copy link
Contributor Author

isaacs commented Jul 3, 2019

Do not land. There's an issue with this build that is fixed in 6.9.2 and (better) in 6.10.0.

@isaacs isaacs closed this Jul 3, 2019
@isaacs isaacs mentioned this pull request Jul 3, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@isaacs @nodejs-github-bot @Trott @addaleax @gengjiawen @trivikr @BethGriggs