Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,n-api: fix metadata for napi_create_threadsafe_function #28410

Merged
merged 1 commit into from
Jun 24, 2019
Merged

doc,n-api: fix metadata for napi_create_threadsafe_function #28410

merged 1 commit into from
Jun 24, 2019

Conversation

richardlau
Copy link
Member

Refs: #27791

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jun 24, 2019
richardlau referenced this pull request Jun 24, 2019
@legendecas @Trott
n-api: make func argument of napi_create_threadsafe_function optional
5705d7b 
PR-URL: #27791
Refs: #27592
Reviewed-By: Gabriel Schulhof <[email protected]>
@cjihrig
Copy link
Contributor

cjihrig commented Jun 24, 2019

👍 to fast tracking this.

@richardlau
Copy link
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3712/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 24, 2019
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 24, 2019
mhdawson
mhdawson approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
doc,n-api: fix metadata for napi_create_threadsafe_function
88db3e4 
PR-URL: nodejs#28410
Refs: nodejs#27791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member Author

Landed in 88db3e4.

@richardlau richardlau merged commit 88db3e4 into nodejs:master Jun 24, 2019
@richardlau richardlau deleted the napi-docs branch June 25, 2019 15:07
targos pushed a commit that referenced this pull request Jul 2, 2019
@richardlau @targos
doc,n-api: fix metadata for napi_create_threadsafe_function
91d5a4d 
PR-URL: #28410
Refs: #27791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @cjihrig @Trott @mhdawson @nodejs-github-bot