http2: remove square brackets from parsed hostname #28406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `http2.connect()` work when using URLs with literal IPv6 addresses. Fixes: nodejs#28216
addaleax
approved these changes
Jun 24, 2019
cjihrig
approved these changes
Jun 24, 2019
Trott
approved these changes
Jun 25, 2019
trivikr
approved these changes
Jun 25, 2019
jasnell
approved these changes
Jun 25, 2019
gengjiawen
reviewed
Jun 25, 2019
lpinca
added
the
author ready
gengjiawen
reviewed
Jun 26, 2019
lib/internal/http2/core.js
Outdated
| @@ -2774,7 +2774,18 @@ function connect(authority, options, listener) { | |||
| const protocol = authority.protocol || options.protocol || 'https:'; | |||
| const port = '' + (authority.port !== '' ? | |||
| authority.port : (authority.protocol === 'http:' ? 80 : 443)); | |||
| const host = authority.hostname || authority.host || 'localhost'; | |||
| let host = ''; | |||
There was a problem hiding this comment.
Looks like host can be default to localhost and remove the last else ?
gengjiawen
approved these changes
Jun 26, 2019
|
Landed in 26b048e. |
lpinca
added a commit
that referenced
this pull request
Jul 1, 2019
Make `http2.connect()` work when using URLs with literal IPv6 addresses. Fixes: #28216 PR-URL: #28406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Make `http2.connect()` work when using URLs with literal IPv6 addresses. Fixes: #28216 PR-URL: #28406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Make `http2.connect()` work when using URLs with literal IPv6 addresses. Fixes: #28216 PR-URL: #28406 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
This was referenced Jul 3, 2019
|
Is there any chance of this getting backported to node 10? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
http2.connect()work when using URLs with literal IPv6addresses.
Fixes: #28216
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes