Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactoring test, reordering arguments #28343

Closed
wants to merge 1 commit into from
Closed

test: refactoring test, reordering arguments #28343

wants to merge 1 commit into from

Conversation

d4vsanchez
Copy link
Contributor

Refactors the test-buffer-inheritance.js test, switches the order of the
arguments to be: 'actual', 'expected'

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Refactors the test-buffer-inheritance.js test, switches the order of the
arguments to be: 'actual', 'expected'
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2019
@ZYSzys ZYSzys added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jun 22, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 22, 2019
@nodejs-github-bot
Copy link
Collaborator

@ZYSzys
Copy link
Member

ZYSzys commented Jun 26, 2019

Landed in 9451343

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@ZYSzys ZYSzys closed this Jun 26, 2019
ZYSzys pushed a commit to zys-contrib/node that referenced this pull request Jun 26, 2019
Refactors the test-buffer-inheritance.js test, switches the order of the
arguments to be: 'actual', 'expected'

PR-URL: nodejs#28343
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
Refactors the test-buffer-inheritance.js test, switches the order of the
arguments to be: 'actual', 'expected'

PR-URL: #28343
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants