Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: use strong reference to domain while active #28313

Closed
wants to merge 1 commit into from
Closed

domain: use strong reference to domain while active #28313

wants to merge 1 commit into from

Commits on Jun 20, 2019

  1. domain: use strong reference to domain while active 

    When an uncaught exception is thrown inside a domain, the domain is
removed from the stack as of 43a5170.
This means that it might not be kept alive as an object anymore,
and may be garbage collected before the `after()` hook can run,
which tries to exit it as well.

Resolve that by making references to the domain strong while it is
active.

Fixes: nodejs#28275
    @addaleax
    addaleax committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    302fc52 View commit details
    Browse the repository at this point in the history