Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] n-api: implement date object #28298

Closed
wants to merge 1 commit into from
Closed

[v10.x] n-api: implement date object #28298

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Implements napi_create_date() as well as napi_is_date() to
allow working with JavaScript Date objects.

PR-URL: #25917

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v10.x labels Jun 19, 2019
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Jun 19, 2019
richardlau
richardlau reviewed Jun 20, 2019
View reviewed changes
doc/api/n-api.md
#### napi_create_date
<!-- YAML
added: REPLACEME
napiVersion: 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napiVersion shouldn't be set for experimental API's? #28330

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau OK, that'll have to be backported as well, then.

@gabrielschulhof gabrielschulhof force-pushed the backport-25917-to-v10.x branch 2 times, most recently from f029352 to 440570a Compare June 25, 2019 19:28
@gabrielschulhof gabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24500/

@mhdawson
Copy link
Member

@BethGriggs can you take a look to see if this should be in 10.16.1?

@mhdawson
Copy link
Member

@BethGriggs also can you remind me if we should have the backported-to-10.x label on this once the PR is ready or is that added once it is landed in the older stream?

@BethGriggs
Copy link
Member

@mhdawson, just trying to get a green CI/track down the failures before landing this one.

We typically add the land-on-v10.x label once the backport PR has landed on the staging branch, whereas the backported-to-v10.x label would be added to the original PR that landed on master.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24512/

@gabrielschulhof gabrielschulhof mentioned this pull request Jul 17, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24630/

@mhdawson
Copy link
Member

@BethGriggs thanks for the clarification.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24702/

@jarrodconnolly
n-api: implement date object
ce01f2f 
Implements `napi_create_date()` as well as `napi_is_date()` to
allow working with JavaScript Date objects.

PR-URL: nodejs#25917
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gabrielschulhof
Copy link
Contributor Author

Rebased.

BethGriggs pushed a commit that referenced this pull request Sep 3, 2019
@jarrodconnolly @BethGriggs
n-api: implement date object
4f41e4f 
Implements `napi_create_date()` as well as `napi_is_date()` to
allow working with JavaScript Date objects.

Backport-PR-URL: #28298
PR-URL: #25917
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs
Copy link
Member

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Sep 3, 2019
@gabrielschulhof gabrielschulhof deleted the backport-25917-to-v10.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @nodejs-github-bot @mhdawson @BethGriggs @richardlau @jarrodconnolly