test: document cpu-prof module and remove unused output argument from getFrames()
#28183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joyeecheung
reviewed
Jun 11, 2019
richardlau
reviewed
Jun 11, 2019
richardlau
approved these changes
Jun 11, 2019
Trott
added
the
author ready
This comment has been minimized.
This comment has been minimized.
joyeecheung
reviewed
Jun 12, 2019
Trott
commented
Jun 12, 2019
|
Guess I should fix the |
jasnell
approved these changes
Jun 14, 2019
|
Landed in 8cdc1bd...d4c7487 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 14, 2019
PR-URL: nodejs#28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 14, 2019
PR-URL: nodejs#28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
PR-URL: #28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
PR-URL: #28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
PR-URL: #28183 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: document cpu-prof module and remove unused
outputargument fromgetFrames()Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes