-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: split test-cpu-prof.js #28170
Closed
Closed
test: split test-cpu-prof.js #28170
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* eslint-disable node-core/require-common-first, node-core/required-modules */ | ||
|
||
'use strict'; | ||
|
||
const common = require('./'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const assert = require('assert'); | ||
|
||
function getCpuProfiles(dir) { | ||
const list = fs.readdirSync(dir); | ||
return list | ||
.filter((file) => file.endsWith('.cpuprofile')) | ||
.map((file) => path.join(dir, file)); | ||
} | ||
|
||
function getFrames(output, file, suffix) { | ||
const data = fs.readFileSync(file, 'utf8'); | ||
const profile = JSON.parse(data); | ||
const frames = profile.nodes.filter((i) => { | ||
const frame = i.callFrame; | ||
return frame.url.endsWith(suffix); | ||
}); | ||
return { frames, nodes: profile.nodes }; | ||
} | ||
|
||
function verifyFrames(output, file, suffix) { | ||
const { frames, nodes } = getFrames(output, file, suffix); | ||
if (frames.length === 0) { | ||
// Show native debug output and the profile for debugging. | ||
console.log(output.stderr.toString()); | ||
console.log(nodes); | ||
} | ||
assert.notDeepStrictEqual(frames, []); | ||
} | ||
|
||
let FIB = 30; | ||
// This is based on emperial values - in the CI, on Windows the program | ||
// tend to finish too fast then we won't be able to see the profiled script | ||
// in the samples, so we need to bump the values a bit. On slower platforms | ||
// like the Pis it could take more time to complete, we need to use a | ||
// smaller value so the test would not time out. | ||
if (common.isWindows) { | ||
FIB = 40; | ||
} | ||
|
||
// We need to set --cpu-interval to a smaller value to make sure we can | ||
// find our workload in the samples. 50us should be a small enough sampling | ||
// interval for this. | ||
const kCpuProfInterval = 50; | ||
const env = { | ||
...process.env, | ||
FIB, | ||
NODE_DEBUG_NATIVE: 'INSPECTOR_PROFILER' | ||
}; | ||
|
||
module.exports = { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
getFrames, | ||
verifyFrames | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
|
||
// Test --cpu-prof without --cpu-prof-interval. Here we just verify that | ||
// we manage to generate a profile since it's hard to tell whether we | ||
// can sample our target function with the default sampling rate across | ||
// different platforms and machine configurations. | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
env | ||
} = require('../common/cpu-prof'); | ||
|
||
{ | ||
tmpdir.refresh(); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof', | ||
fixtures.path('workload', 'fibonacci.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 0) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 0); | ||
const profiles = getCpuProfiles(tmpdir.path); | ||
assert.strictEqual(profiles.length, 1); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
'use strict'; | ||
|
||
// This tests that relative --cpu-prof-dir works. | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
verifyFrames | ||
} = require('../common/cpu-prof'); | ||
|
||
// relative --cpu-prof-dir | ||
{ | ||
tmpdir.refresh(); | ||
const dir = path.join(tmpdir.path, 'prof'); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof', | ||
'--cpu-prof-interval', | ||
kCpuProfInterval, | ||
'--cpu-prof-dir', | ||
dir, | ||
fixtures.path('workload', 'fibonacci.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 0) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 0); | ||
assert(fs.existsSync(dir)); | ||
const profiles = getCpuProfiles(dir); | ||
assert.strictEqual(profiles.length, 1); | ||
verifyFrames(output, profiles[0], 'fibonacci.js'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
'use strict'; | ||
|
||
// This tests that --cpu-prof-dir and --cpu-prof-name works together. | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
verifyFrames | ||
} = require('../common/cpu-prof'); | ||
|
||
{ | ||
tmpdir.refresh(); | ||
const dir = path.join(tmpdir.path, 'prof'); | ||
const file = path.join(dir, 'test.cpuprofile'); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof', | ||
'--cpu-prof-interval', | ||
kCpuProfInterval, | ||
'--cpu-prof-name', | ||
'test.cpuprofile', | ||
'--cpu-prof-dir', | ||
dir, | ||
fixtures.path('workload', 'fibonacci.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 0) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 0); | ||
assert(fs.existsSync(dir)); | ||
const profiles = getCpuProfiles(dir); | ||
assert.deepStrictEqual(profiles, [file]); | ||
verifyFrames(output, file, 'fibonacci.js'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
'use strict'; | ||
|
||
// This tests that relative --cpu-prof-dir works. | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
verifyFrames | ||
} = require('../common/cpu-prof'); | ||
|
||
// relative --cpu-prof-dir | ||
{ | ||
tmpdir.refresh(); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof', | ||
'--cpu-prof-interval', | ||
kCpuProfInterval, | ||
'--cpu-prof-dir', | ||
'prof', | ||
fixtures.path('workload', 'fibonacci.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 0) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 0); | ||
const dir = path.join(tmpdir.path, 'prof'); | ||
assert(fs.existsSync(dir)); | ||
const profiles = getCpuProfiles(dir); | ||
assert.strictEqual(profiles.length, 1); | ||
verifyFrames(output, profiles[0], 'fibonacci.js'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
'use strict'; | ||
|
||
// This tests that --cpu-prof-dir works for workers. | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
getFrames | ||
} = require('../common/cpu-prof'); | ||
|
||
// --cpu-prof-dir with worker | ||
{ | ||
tmpdir.refresh(); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof-interval', | ||
kCpuProfInterval, | ||
'--cpu-prof-dir', | ||
'prof', | ||
'--cpu-prof', | ||
fixtures.path('workload', 'fibonacci-worker.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 0) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 0); | ||
const dir = path.join(tmpdir.path, 'prof'); | ||
assert(fs.existsSync(dir)); | ||
const profiles = getCpuProfiles(dir); | ||
assert.strictEqual(profiles.length, 2); | ||
const profile1 = getFrames(output, profiles[0], 'fibonacci.js'); | ||
const profile2 = getFrames(output, profiles[1], 'fibonacci.js'); | ||
if (profile1.frames.length === 0 && profile2.frames.length === 0) { | ||
// Show native debug output and the profile for debugging. | ||
console.log(output.stderr.toString()); | ||
console.log('CPU path: ', profiles[0]); | ||
console.log(profile1.nodes); | ||
console.log('CPU path: ', profiles[1]); | ||
console.log(profile2.nodes); | ||
} | ||
assert(profile1.frames.length > 0 || profile2.frames.length > 0); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
'use strict'; | ||
|
||
// This tests that --cpu-prof generates CPU profile when event | ||
// loop is drained. | ||
// TODO(joyeecheung): share the fixutres with v8 coverage tests | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
verifyFrames | ||
} = require('../common/cpu-prof'); | ||
|
||
{ | ||
tmpdir.refresh(); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof', | ||
'--cpu-prof-interval', | ||
kCpuProfInterval, | ||
fixtures.path('workload', 'fibonacci.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 0) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 0); | ||
const profiles = getCpuProfiles(tmpdir.path); | ||
assert.strictEqual(profiles.length, 1); | ||
verifyFrames(output, profiles[0], 'fibonacci.js'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
'use strict'; | ||
|
||
// This tests that --cpu-prof generates CPU profile when | ||
// process.exit(55) exits the process. | ||
|
||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
common.skipIfInspectorDisabled(); | ||
|
||
const assert = require('assert'); | ||
const { spawnSync } = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
const { | ||
getCpuProfiles, | ||
kCpuProfInterval, | ||
env, | ||
verifyFrames | ||
} = require('../common/cpu-prof'); | ||
|
||
{ | ||
tmpdir.refresh(); | ||
const output = spawnSync(process.execPath, [ | ||
'--cpu-prof', | ||
'--cpu-prof-interval', | ||
kCpuProfInterval, | ||
fixtures.path('workload', 'fibonacci-exit.js'), | ||
], { | ||
cwd: tmpdir.path, | ||
env | ||
}); | ||
if (output.status !== 55) { | ||
console.log(output.stderr.toString()); | ||
} | ||
assert.strictEqual(output.status, 55); | ||
const profiles = getCpuProfiles(tmpdir.path); | ||
assert.strictEqual(profiles.length, 1); | ||
verifyFrames(output, profiles[0], 'fibonacci-exit.js'); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.