Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update kernel and glibc reqs for PPCle #28162

Closed
wants to merge 3 commits into from

Conversation

mhdawson
Copy link
Member

We've moved master to build on centos7 for PPCle, adjust
the glibc and kernel levels accordingly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

We've moved master to build on centos7 for PPCle, adjust
the glibc and kernel levels accordingly.
@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 10, 2019
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Show resolved Hide resolved
@mhdawson
Copy link
Member Author

@richardlau thanks for catching that, fixed.

@mhdawson
Copy link
Member Author

@sam-github can you review as well?

@mhdawson mhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2019
@mhdawson
Copy link
Member Author

mhdawson commented Jun 13, 2019

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp-ish LGTM

@sam-github
Copy link
Contributor

Even after adjusting the format of #28162 (comment), git node land says No CI runs detected, not sure why.

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Jun 13, 2019
We've moved master to build on centos7 for PPCle, adjust
the glibc and kernel levels accordingly.

PR-URL: nodejs#28162
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@richardlau
Copy link
Member

Landed in 8cdc1bd

@richardlau richardlau closed this Jun 13, 2019
@richardlau
Copy link
Member

Even after adjusting the format of #28162 (comment), git node land says No CI runs detected, not sure why.

nodejs/node-core-utils#354 will fix this.

BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
We've moved master to build on centos7 for PPCle, adjust
the glibc and kernel levels accordingly.

PR-URL: #28162
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
targos pushed a commit that referenced this pull request Jun 18, 2019
We've moved master to build on centos7 for PPCle, adjust
the glibc and kernel levels accordingly.

PR-URL: #28162
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@mhdawson mhdawson deleted the ppcversions branch September 30, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants