tls: remove unnecessary set of DEFAULT_MAX_VERSION #28147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly, an error occurred when I tried to trigger a build. :( |
addaleax
approved these changes
Jun 10, 2019
sam-github
approved these changes
Jun 10, 2019
cjihrig
approved these changes
Jun 10, 2019
jasnell
approved these changes
Jun 10, 2019
|
Do we need to remove |
lpinca
approved these changes
Jun 10, 2019
richardlau
approved these changes
Jun 11, 2019
No. This PR doesn't remove |
trivikr
approved these changes
Jun 11, 2019
Trott
approved these changes
Jun 11, 2019
|
Re-build of failing node-test-commit-linux-containered (🔴) |
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE.
danbev
force-pushed
the
tls_default_max_version
branch
from
2aec0f5 to
85777f8
Compare
|
Re-run of failing node-test-commit-osx (✔️) |
|
Landed in c925d1d. |
danbev
added a commit
that referenced
this pull request
Jun 17, 2019
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. PR-URL: #28147 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. PR-URL: #28147 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jun 18, 2019
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. PR-URL: #28147 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes what looks like an unnecessary setting of
exports.DEFAULT_MAX_VALUE.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes