Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-tty-wrap from status file #28129

Merged
merged 1 commit into from
Jun 10, 2019
Merged

test: remove test-tty-wrap from status file #28129

merged 1 commit into from
Jun 10, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 8, 2019

The test is believed to no longer be unreliable on AIX. Remove the flaky
designation from the appropriate status file.

Closes: #9728

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Jun 8, 2019
@Trott Trott mentioned this pull request Jun 8, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23704/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2019
@Trott
test: remove test-tty-wrap from status file
d7f60b7 
The test is believed to no longer be unreliable on AIX. Remove the flaky
designation from the appropriate status file.

Closes: nodejs#9728

PR-URL: nodejs#28129
Fixes: nodejs#9728
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 10, 2019

Landed in d7f60b7

@Trott Trott merged commit d7f60b7 into nodejs:master Jun 10, 2019
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
test: remove test-tty-wrap from status file
d6791d1 
The test is believed to no longer be unreliable on AIX. Remove the flaky
designation from the appropriate status file.

Closes: #9728

PR-URL: #28129
Fixes: #9728
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
@Trott Trott deleted the whoopsy branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIX: Intermittent failure on pseudo-tty/test-tty-wrap
9 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig @richardlau @gireeshpunathil @BridgeAR @trivikr