Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update broken/foundation links in README.md #28119

Closed
wants to merge 1 commit into from
Closed

doc: Update broken/foundation links in README.md #28119

wants to merge 1 commit into from

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Jun 7, 2019

Was looking at the README and noticed that two links were outdated:

  • The Node.js website link was broken.
  • There was still a reference to the Node.js Foundation, rather than the OpenJS Foundation.

Figured I could just PR rather than bothering someone else about it 💖

@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 7, 2019
@richardlau
Copy link
Member

#28042 from a first time contributor also seeks to address the broken website link.

@Trott
Copy link
Member

Trott commented Jun 10, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3667/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2019
@Trott Trott mentioned this pull request Jun 13, 2019
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Jun 13, 2019

Landed in 0a3885e

@Trott Trott closed this Jun 13, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 13, 2019
@bnb @Trott
doc: update broken/foundation links in README.md
0a3885e 
PR-URL: nodejs#28119
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@bnb @BridgeAR
doc: update broken/foundation links in README.md
4d6262f 
PR-URL: #28119
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
@devsnek devsnek deleted the bnb/update-readme-markdown-links branch August 14, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bnb @nodejs-github-bot @richardlau @Trott @jasnell @lpinca @cjihrig @trivikr