-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 27962 #28083
Revert 27962 #28083
Conversation
This reverts commit 39d6da8.
This reverts commit 2abaa1a.
This reverts commit f212fee.
This reverts commit 3e5b20c.
This reverts commit 7aa79be.
This reverts commit c49e378.
This reverts commit 6925f41.
This reverts commit b422561.
This reverts commit 6adeae6.
This reverts commit 5d08697.
This reverts commit b250085.
This reverts commit 198162a.
This reverts commit c420972.
This reverts commit f5e6ac2.
This reverts commit 56d3383.
This reverts commit ee00111.
This reverts commit 8091df0.
I suggest this be fast-tracked when it passes CI, it fixes test failures introduced in #27962 Please thumbs-up this if you agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to fast-tracking
As a heads-up, I won't be available for a couple hours to land this, so if it gets some fasttrack votes and passes CI, anyone who has the time feel free to land it. |
PR-URL: nodejs#28083 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Fast-track landed in 965ffc4 |
https://ci.nodejs.org/job/node-test-commit/29189/ ✔️ Re running CI since there seems to get some git whitespace artifacts when rebasing. test/fixtures/msca.pem | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/test/fixtures/msca.pem b/test/fixtures/msca.pem
index 247368e625..82ae5e1bec 100644
--- a/test/fixtures/msca.pem
+++ b/test/fixtures/msca.pem
CRLF->LF
test/fixtures/foafssl.key | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/fixtures/foafssl.key b/test/fixtures/foafssl.key
index 62e953a67f..facbec5541 100644
--- a/test/fixtures/foafssl.key
+++ b/test/fixtures/foafssl.key
@@ -1,6 +1,6 @@
Bag Attributes
friendlyName: Me's Not a Certification Authority ID
- localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
+ localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
Key Attributes: <No Attributes>
-----BEGIN PRIVATE KEY-----
MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQCm9EqcJXkUMSFP
test/fixtures/foafssl.crt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/fixtures/foafssl.crt b/test/fixtures/foafssl.crt
index f4b5905e37..4a95dcd714 100644
--- a/test/fixtures/foafssl.crt
+++ b/test/fixtures/foafssl.crt
@@ -1,6 +1,6 @@
Bag Attributes
friendlyName: Me's Not a Certification Authority ID
- localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
+ localKeyID: 98 CC 02 91 83 8D 14 4A 60 40 B7 11 E8 EF A9 01 4B D7 16 8A
subject=/O=FOAF+SSL/OU=The Community Of Self Signers/UID=http://example.com/#me/CN=Me
issuer=/O=FOAF+SSL/OU=The Community of Self Signers/CN=Not a Certification Authority
-----BEGIN CERTIFICATE----- |
thanks @refack |
PR-URL: #28083 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes