Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: handle exceptions from ToDetailString() #28019

Closed
wants to merge 1 commit into from
Closed

src: handle exceptions from ToDetailString() #28019

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jun 2, 2019

These methods may fail if execution is terminating.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: handle exceptions from ToDetailString()
747a305 
These methods may fail if execution is terminating.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 2, 2019
Trott
Trott approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I imagine this would be pretty difficult to test reliably, or maybe even at all?

@addaleax
Copy link
Member Author

addaleax commented Jun 2, 2019

@Trott Yes – it’s not possible to test this reliably, and the race condition window is rather small.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23566/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23735/

@addaleax
Copy link
Member Author

addaleax commented Jun 9, 2019

Landed in 626f243

@addaleax addaleax closed this Jun 9, 2019
@addaleax addaleax deleted the to-detail-string branch June 9, 2019 20:35
addaleax added a commit that referenced this pull request Jun 9, 2019
@addaleax
src: handle exceptions from ToDetailString()
626f243 
These methods may fail if execution is terminating.

PR-URL: #28019
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@addaleax @BridgeAR
src: handle exceptions from ToDetailString()
8849eb2 
These methods may fail if execution is terminating.

PR-URL: #28019
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @bnoordhuis @Trott @targos @cjihrig @BridgeAR