-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for util.inspect #27906
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test case for util.inspect with 'depth' option set to 'null' and with that has a custom inspect function attached
addaleax
approved these changes
May 26, 2019
cjihrig
approved these changes
May 26, 2019
BridgeAR
approved these changes
May 26, 2019
BridgeAR
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
May 26, 2019
ryzokuken
approved these changes
May 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ChALkeR
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
gireeshpunathil
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 27, 2019
ZYSzys
approved these changes
May 27, 2019
Landed in 3b50bde 🎉 |
ZYSzys
pushed a commit
to zys-contrib/node
that referenced
this pull request
May 28, 2019
add test case for util.inspect with 'depth' option set to 'null' and with that has a custom inspect function attached PR-URL: nodejs#27906 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 31, 2019
add test case for util.inspect with 'depth' option set to 'null' and with that has a custom inspect function attached PR-URL: #27906 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test case for util.inspect with 'depth' option set to 'null'
and with that has a custom inspect function attached
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes