doc: createRequire() improvements #27762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
May 18, 2019
antsmartian
approved these changes
May 20, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23231/ EDIT(cjihrig): CI was yellow. |
Update the example to use import and import.meta.url instead of require() and require.resolve(). PR-URL: nodejs#27762 Fixes: nodejs#27758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
This commit replaces createRequireFromPath() references with createRequire() references. PR-URL: nodejs#27762 Fixes: nodejs#27758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
|
Landed in 64182e9...1b381d6. |
BridgeAR
pushed a commit
that referenced
this pull request
May 21, 2019
Update the example to use import and import.meta.url instead of require() and require.resolve(). PR-URL: #27762 Fixes: #27758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
May 21, 2019
This commit replaces createRequireFromPath() references with createRequire() references. PR-URL: #27762 Fixes: #27758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
Update the example to use import and import.meta.url instead of require() and require.resolve(). PR-URL: nodejs/node#27762 Fixes: nodejs/node#27758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
Update the
createRequire()example to useimportandimport.meta.urlinstead ofrequire()andrequire.resolve().I'm not so sure about the change here to
.eslintrc.js. Based on eslint/eslint#8148, it doesn't seem possible to configure theparserOptions.sourceTypeper code block. If it is possible, I'm happy to make the change. Another option would be to just disable eslint for that code block.Second commit:
This commit replaces
createRequireFromPath()references withcreateRequire()references.Fixes: #27758
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes