Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove memory_tracker-inl.h from header files #27755

Closed
wants to merge 3 commits into from
Closed

src: remove memory_tracker-inl.h from header files #27755

wants to merge 3 commits into from

Commits on May 22, 2019

  1. src: move ThreadPoolWork inlines into a -inl.h 

    The presence of the inline definitions in node_internals.h can cause all
files that include node_internals.h to depend on util-inl.h, even if
they never use ThreadPoolWork. Whether this happens depends on the
toolchain, gcc will strip unused definitions, clang won't.
    @sam-github
    sam-github committed May 22, 2019
    Configuration menu
    Copy the full SHA
    1d2666b View commit details
    Browse the repository at this point in the history

  2. src: remove memory_tracker-inl.h from header files 

    Inline headers should only be included into the .cc files that use them.
    @sam-github
    sam-github committed May 22, 2019
    Configuration menu
    Copy the full SHA
    ad131e2 View commit details
    Browse the repository at this point in the history

  3. src: remove env-inl.h from header files 

    Inline headers should only be included into the .cc files that use them.
    @sam-github
    sam-github committed May 22, 2019
    Configuration menu
    Copy the full SHA
    0af62cc View commit details
    Browse the repository at this point in the history