Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: DRY isString() in lint rules #27719

Closed
wants to merge 1 commit into from
Closed

tools: DRY isString() in lint rules #27719

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 15, 2019

This commit makes isString() a reusable utility function for core's custom ESLint rules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: DRY isString() in lint rules
422fc7f 
This commit makes isString() a reusable utility
function for core's custom ESLint rules.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3530

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 15, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 16, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/23137/

EDIT(cjihrig): CI was green.

@shisama shisama added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 16, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 18, 2019
@cjihrig @Trott
tools: decrease code duplication for isString() in lint rules
af83b79 
This commit makes isString() a reusable utility
function for core's custom ESLint rules.

PR-URL: nodejs#27719
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented May 18, 2019

Landed in af83b79

@Trott Trott closed this May 18, 2019
targos pushed a commit that referenced this pull request May 18, 2019
@cjihrig @targos
tools: decrease code duplication for isString() in lint rules
0e16b35 
This commit makes isString() a reusable utility
function for core's custom ESLint rules.

PR-URL: #27719
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig deleted the lint-rules branch May 18, 2019 12:40
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @Trott @lpinca @BridgeAR @shisama @ZYSzys