Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update dmn to 2.2.2 #27686

Closed
wants to merge 1 commit into from
Closed

tools: update dmn to 2.2.2 #27686

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 14, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3514

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 14, 2019
@Trott Trott requested a review from BridgeAR May 14, 2019 02:48
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
@Trott
Copy link
Member Author

Trott commented May 16, 2019 •
edited
Loading

Landed in ac2f2cd.

@Trott Trott closed this May 16, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 16, 2019
@Trott
tools: update dmn to 2.2.2
ac2f2cd 
PR-URL: nodejs#27686
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 17, 2019
@Trott @targos
tools: update dmn to 2.2.2
ea62f4a 
PR-URL: #27686
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@Trott Trott deleted the update-dmn-2.2.2 branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @antsmartian @BridgeAR @trivikr @ZYSzys