Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add arm64 to vcbuild.bat help message #27683

Closed
wants to merge 1 commit into from
Closed

build: add arm64 to vcbuild.bat help message #27683

wants to merge 1 commit into from

Conversation

jkunkee
Copy link
Contributor

@jkunkee jkunkee commented May 13, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels May 13, 2019
@joaocgreis
Copy link
Member

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/23140/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23140/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23141/

@Trott
Copy link
Member

Trott commented May 17, 2019

Landed in 2a24aa2

@Trott Trott closed this May 17, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 17, 2019
@jkunkee @Trott
build: add arm64 to vcbuild.bat help message
2a24aa2 
PR-URL: nodejs#27683
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 18, 2019
@jkunkee @targos
build: add arm64 to vcbuild.bat help message
e058900 
PR-URL: #27683
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@joaocgreis joaocgreis joaocgreis approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkunkee @joaocgreis @nodejs-github-bot @Trott @bnoordhuis @richardlau