Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: DRY isRequireCall() in lint rules #27680

Merged
merged 1 commit into from
May 15, 2019
Merged

tools: DRY isRequireCall() in lint rules #27680

merged 1 commit into from
May 15, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 13, 2019

This commit makes isRequireCall() a reusable utility function for core's custom ESLint rules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3506

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/23115/

EDIT(cjihrig): CI was yellow.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
@cjihrig
tools: DRY isRequireCall() in lint rules
03d4353 
This commit makes isRequireCall() a reusable utility
function for core's custom ESLint rules.

PR-URL: nodejs#27680
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@cjihrig cjihrig merged commit 03d4353 into nodejs:master May 15, 2019
@cjihrig cjihrig deleted the lint-rules branch May 15, 2019 19:20
targos pushed a commit that referenced this pull request May 17, 2019
@cjihrig @targos
tools: DRY isRequireCall() in lint rules
d2dad0b 
This commit makes isRequireCall() a reusable utility
function for core's custom ESLint rules.

PR-URL: #27680
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @Trott @richardlau @BridgeAR @ZYSzys