Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move orangemocha to Collaborator Emeriti list #27626

Closed
wants to merge 1 commit into from
Closed

meta: move orangemocha to Collaborator Emeriti list #27626

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 9, 2019

Alexis confirmed in email that that they should be moved to
the Emeriti list.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
meta: move orangemocha to Collaborator Emeriti list
be710f4 
Alexis confirmed in email that that they should be moved to
the Emeriti list.
@Trott Trott added the meta Issues and PRs related to the general management of the project. label May 9, 2019
@Trott Trott requested a review from orangemocha May 9, 2019 20:18
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3473

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 9, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2019
@Trott
Copy link
Member Author

Trott commented May 9, 2019

Given Alexis's approval on this PR, I'd like to fast-track. Upvote here if you're a Collaborator and agree. Thanks.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 10, 2019
@Trott
meta: move orangemocha to Collaborator Emeriti list
d88fcf3 
Alexis confirmed in email that that they should be moved to
the Emeriti list.

PR-URL: nodejs#27626
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 10, 2019

Landed in d88fcf3

@Trott Trott closed this May 10, 2019
targos pushed a commit that referenced this pull request May 10, 2019
@Trott @targos
meta: move orangemocha to Collaborator Emeriti list
876441e 
Alexis confirmed in email that that they should be moved to
the Emeriti list.

PR-URL: #27626
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@Trott Trott deleted the orangemocha-to-emeritus branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@orangemocha orangemocha orangemocha approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @orangemocha @targos @cjihrig @richardlau @BridgeAR