Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unneeded --expose-internals #27608

Closed
wants to merge 1 commit into from
Closed

test: remove unneeded --expose-internals #27608

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 8, 2019

test/wpt/test-timers.js does not appear to need the --expose-internals
flag. Remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove unneeded --expose-internals
4e60428 
test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.
@Trott Trott requested a review from joyeecheung May 8, 2019 04:57
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3462

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 8, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23001/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2019
@Trott
Copy link
Member Author

Trott commented May 10, 2019

Landed in 556de23

@Trott Trott closed this May 10, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 10, 2019
@Trott
test: remove unneeded --expose-internals
556de23 
test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.

PR-URL: nodejs#27608
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 11, 2019
@Trott @targos
test: remove unneeded --expose-internals
d7fcd75 
test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.

PR-URL: #27608
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@Trott Trott deleted the remove-uneeded-flag branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @cjihrig @joyeecheung @richardlau @BridgeAR @trivikr @ZYSzys