-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: Move AnnaMag to Collaborator Emeriti list #27603
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
meta
Issues and PRs related to the general management of the project.
label
May 7, 2019
BridgeAR
approved these changes
May 7, 2019
cjihrig
approved these changes
May 7, 2019
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent them an email asking about becoming Emeritus but did not get a response. It's easy enough to re-onboard someone back to active status if they become active again, so I think this is a pretty safe change to make. I'll specifically request a review of this change from them so they get notified and can comment/review/block/approve/etc. this.
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 8, 2019
antsmartian
approved these changes
May 8, 2019
fhinkel
approved these changes
May 9, 2019
trivikr
approved these changes
May 9, 2019
Landed in ec62906 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 10, 2019
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent them an email asking about becoming Emeritus but did not get a response. It's easy enough to re-onboard someone back to active status if they become active again, so I think this is a pretty safe change to make. I'll specifically request a review of this change from them so they get notified and can comment/review/block/approve/etc. this. PR-URL: nodejs#27603 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 10, 2019
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent them an email asking about becoming Emeritus but did not get a response. It's easy enough to re-onboard someone back to active status if they become active again, so I think this is a pretty safe change to make. I'll specifically request a review of this change from them so they get notified and can comment/review/block/approve/etc. this. PR-URL: #27603 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Congratulations!
Hope to see you back some time! Take care! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent
them an email asking about becoming Emeritus but did not get a response.
It's easy enough to re-onboard someone back to active status if they
become active again, so I think this is a pretty safe change to make.
I'll specifically request a review of this change from them so they get
notified and can comment/review/block/approve/etc. this.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes